Embedded Commas in Vendor Names broken in shopify querying and admin ui

The store of a client of mine has commas in virtually all their vendor names, which means that historically I have escaped those commas in queries within GraphQL queries that allow search queries using shopify’s query syntax.

I had noticed a bug before that meant that you couldn’t search for these vendors in the products query but you could in the productVariants query. this was a bit of a pain for me, but I could work round it.

My client has noticed that now there have been UI changes, that shopify’s admin UI will no longer allow them to do vendor searches correctly as whenever you pick the vendor from the list the query looks like it should work but no products or inventory etc are returned. This looks like the behaviour I was seeing in the search syntax leaking into the [new] UI.

I think it’s unfortunate that shopify allow commas to be put in vendor strings and then not allow the queries to work, so that suggests to me it’s a bug. I’m currently considering bulk updating the vendor properties - but they will get persisted in old order line items which is a real pain!

To observe the query in GraphQL Explorer create a product with a vendor named “Dave, London” and try to query the products and you’ll get nothing. To query correctly you would have to escape the query as follows: vendor:\"Dave, London\". If you change the query to vendor:Dave* the products will appear.

This did used to work in productVariants but it no longer does (even on the identical API version) so it seems they’ve changed their indexes?

Not sure whether this can be fixed, but raising it here as a warning not to use commas in things you want to filter in either the UI or shopify’s query syntax.

Any comments from any shopify developers to confirm or deny the behaviour change and whether it might be reverted gratefully received.

1 Like

Hey @iamdavehart,

Thanks for reporting this. I was able to replicate the same on my own test store.

I’ve looked in to this further and found that this is a known issue. I don’t have a timeline on a resolution, but we will update here when there are changes.