Help with 'shopify theme push' not updating theme files

Shopify CLI and Libraries
1

Hi There, I’m obviously missing something basic so sorry of this is easy.

STEPS:

  • Created a copy of the live theme on the live site Dawn-11-New-Home
  • Created a local theme directory named identically cd into it
  • Used shopify theme pull and chose the copy to pull
  • Used shopify theme serve
  • Used resulting URLs to test, edit files, edit theme in the editor (using URL provided in Terminal)
  • Once ready, used shopify theme push to push changes
  • Selected Dawn-11-New-Home to push changes to
  • The push worked without errors in CLI
  • Went to the live store and opened Dawn-11-New-Home in the editor
  • But none of the local changes were there
  • Tried push again, no joy

Can anyone see what I’ve done wrong and why the changes didn’t push?

Any pointers in the right direction much appreciated.

Cheers, Ben

2

Hi Ben,

When you say you

Went to the live store and opened Dawn-11-New-Home in the editor

Are you opening the code editor or the drag and drop theme editor? Are the changes you’re making code changes or changes in the theme editor?

1 Like
3

Thanks for the reply, the answer is both…

  • Pulled and served the theme locally
  • Edited a section file locally in VS Code
  • Opened the content editor using the URL provided in Terminal after serving
  • Made content changes (using the section file edited in VS Code)
  • Saved content editor changes
  • Previewed changes (using the URL provided in Terminal after serving)
  • Pushed the theme
  • Opened the theme in the content editor from the admin of the live site

Just to be clear, this was all on a duplicate of the live theme as noted in the original post and the time stamp of ‘Last saved’ seemed to match the time of the push.

Does round-tripping like this work better via a git repo maybe? Or should that have worked? Have done this all before so feel like I’m missing something basic sorry.

Cheers, Ben

4

This flow should have worked - especially if there’s no errors appearing in terminal. You could try something very simple to test like just adding {{ shop.name }} to theme.liquid somewhere, so it’s visible and then pushing this change and check if it’s being picked up on the live store.

Another thing you could try is to use the GitHub Integration: Shopify GitHub integration for themes

1 Like
5

Thanks Liam, maybe I’ve got this wrong?

Should saved content editor changes made using the URL displayed in Terminal after theme serve get saved and pushed?

Have run several tests and changes made using the editor URL don’t get pushed back to Shopify for some reason.

Will hook this all up to Github and test as well.

6

I think that’s where the misunderstanding is. Changes you make in the editor in local dev are not pushed to the live store. The preview editor URL that’s generated by the CLI is to preview and test code changes you make that wouldn’t be visible on the front-end theme preview, eg: if you’re adding new section settings.

7

Got it, all editor changes need to be made on the store version of the theme. Cheers

1 Like