Index filters view modal still using polaris

App Bridge
1

The modals used for saving/creating views in IndexFilters is still using polaris which also means the overlay/backdrop is contained with the app iframe. There is no way to override this too as the onCreateNewView opens the modal.

Considering the Polaris Modal is now deprecated, and I assume would be a fail if trying to go for BFS, this needs updating asap.

It either needs to use the app bridge modal, or at least let us control the entire action and remove opening the polaris modal.

EDIT: It’s also not possible to handle the loading state of the button which is not great UI, we need more control of this. Changing the modal title aswell ideally. This will all be possible if we can just attach an app bridge modal ourselves and IndexFilters stops opening the polaris modal automatically.

2

Hey @Luke,

Thanks for reporting! This won’t cause a fail for BFS as the team is aware that certain Polaris components still render as Polaris modals (i.e. only overlaying the app frame). Agreed that this experience can be improved though, appreciate the feedback.

3

Thanks for the reply @Charlie-Shopify. Good to know it won’t fail BFS, but in terms of consistency it isn’t the greatest experience. What’s the timelines like on getting some updates in place for this?

Whether it be the app bridge modal replacing the Polaris one, or can you give us a new prop that will allow us to create the modals ourselves?