Polaris 2.0.0-rc.1: s-box padding and container query values ignored

Polaris
1

Since rc.1 landed on polaris-2.0-rc.js, layouts that were fine on rc.0 have broken in our embedded app. No code change on our side, just a reload.

1. @container responsive values are ignored

Both branches of a container query render at once. This pattern, used to swap a desktop and mobile layout, now shows both:

<s-query-container>
  <s-box display="@container (inline-size <= 650px) none, auto">Desktop layout</s-box>
  <s-box display="@container (inline-size <= 650px) auto, none">Mobile layout</s-box>
</s-query-container>

On rc.0 only one box showed. On rc.1 both are visible at every width.

2. Padding has disappeared everywhere

Plain, non-responsive padding on s-box is ignored. This renders with no padding at all on rc.1:

<s-box paddingBlock="base" paddingInline="base">Content</s-box>

The same goes for the page itself: content inside s-page sits flush against the left and right edges of the iframe, and section content has lost its inset. Tables inside s-section padding="none" look correct, but everything around them has no gutter.

Both of these may be one bug: s-box ignoring its layout props, display and padding alike.

3. Everything else

These are the two we’ve confirmed so far, from a few minutes of clicking around. Given how widely responsive values are used, I’d expect more to be affected (grid column templates, responsive padding and gap).

The new table styling in rc.1 looks great, by the way. It’s what we were missing in rc.0.

Is this a known regression, and is there a way to pin rc.0 in the meantime?

Sorry for the tag @David-Shopify but thought best letting you know as 2.0 is basically unusable now.

Reference: What's new in Polaris 2.0.0-rc.1 - Shopify developer changelog

3

Hey folks, we are going to roll back while we investigate the cause of the issue. Apologies this was missed.

4

Please stop with these AI/robotic replies.

5

This should be rolled back now, and we have identified the root cause of the issue. Thanks for report @Luke

6

Thanks David, much appreciated!

7

@David-Shopify Just curious, do you have an estimated timeline for 2.0 to become stable?

8

@gregolive I don’t have an exact timeline to share at the moment, we’re still making some adjustments to components as we continue to rollout the Shopify admin’s new style to merchants, and based on feedback we are receiving during the release candidate window.

9

Makes sense, thanks for getting back to me!