S-icon missing "magic" icon

Hey team

I’ve noticed the s-icon component is missing the magic icon.

Can the team add this missing icon?

Polaris icon [magic]:

Polaris compnent [s-icon]:

Also gift icon does not render when using <s-icon type="gift"></s-icon>

Hi @releod :waving_hand: - thanks for flagging this. I’m happy to look into this internally to see if this is intended and loop back with you on both questions.

For the issue related to the gift icon, would you be able to share a snippet of your implementation where you’re seeing this and a screenshot or video? Just want to see if I can replicate this on my end as well - hope to speak soon! :slight_smile:

The magic icons have been reserved for internal-only use.

There is no gift icon; note that an icon with that name does not exist in this list @storybook/core - Storybook

Should these components not match Polaris ?

Gift is listed here:

The team should consider the app developer time needed if these components have unique edge cases (magic icon not being permitted is a bit wacky).

Switching from old to new components means additional edge case testing is needed, the expectation is not that s-icon has a subset of Polaris icon abilities..

Hope the team can fix..

I believe gift-card is likely the same icon as what gift was, but I’ll create an internal issue to track this down. Thanks!

I’ve heard back from our design team and it sounds like gift is not in the plan to release at the moment.

Thx @Anthony_Frehner - appreciate your help!

Gift is usually like :wrapped_gift:, and gift card is more rectangular (like a physical prepaid card)

1 Like

That’s a bummer, it’s been widely available in Checkout extension components as well:

Since Polaris is being promoted to app developers as a new unified system. It seems off-brand to have components like this working on a subset of Polaris - which many any apps have in production right now.

Hope the various teams can get aligned, it makes using these components (currently) a higher risk, and hard for us as app developers to know what to expect.

We use the gift icon, we use the magic icon, but I am going to revert usage of new components until there is further unification.

These may seem like small details, but for those who are charged with implementing the small details.. it makes a big difference to us. (See previous thread about page layout shifting drastically due to font handling).

It’s not always a quick issue to work out, so it is using our developers time in less than ideal ways.

Just some feedback, hope it helps. :man_shrugging:

1 Like