Hello,
When using the as part of a secondary actions, the buttons don’t show any icon, and the tone=”critical” does not show up neither. Shopify supports it on their own admin so it would be nice to have it as well for apps :).
Hello,
When using the as part of a secondary actions, the buttons don’t show any icon, and the tone=”critical” does not show up neither. Shopify supports it on their own admin so it would be nice to have it as well for apps :).
Hi Michaël,
Thanks for the feedback on the styling of these buttons! ![]()
We’ll consider this for a future update, though I can’t provide a timeline for when we might implement it.
+1
similar to <s-page> secondary-actions, no button icons are shown
We have added in support for icons and the critical tone for the s-menu component. Let me know if you encounter any issues!
@Patrick_Jakubik Thanks for adding your feedback
Let me see if we can get it added there too.
Hello @Paige-Shopify , just tried again but icons are still not working when using s-menu in the s-page. Is it currently being deployed?
Oops sorry, turns out I just made a mistake in my test after trying to get it to work!
We do have some eyes on it at the moment so I’ll leave it those folks to provide an update ![]()
Just providing an update here that this is in our to-do list to resolve, but we’re not able to provide an ETA at this time.
Icons seem to be visible now, but tones are still missing. Any update on this @Paige-Shopify?
This is how s-menu looks when a secondary action of s-page:
Same code but not a secondary action of s-page:
Hi @nunof, good question! We’ll have a follow-up fix for the tones coming soon ![]()