Save Bar Loading State

App Bridge
1

Up until yesterday, we were able to have the primary save bar button show a loading state by setting loading=”” on the button. However, today this no longer works, along with some other features. For example, yesterday the <s-page heading=”Page Name”> worked on the /app page of our app, but today it does not and only shows the app name.

The save bar is the biggest issue, but both issues are instances of this larger issue where app-bridge/polaris can just randomly change overnight, sometimes breaking stuff, and we aren’t given any warnings, update logs, etc.

We are doing our best to be open minded and embrace the recent changes, but it makes it really hard to justify using these libraries/components when we can’t rely on them to behave consistently.

2

Can I know what shop and what app is this?

3

It’s not public yet, but the app is called Dynamic Product Banners and you can find it on the dev store plug-metaobjects-testing.myshopify.com.

4

Is it still happening? May I have a quick steps to reproduce please?

5

It just started working again a second ago. Didn’t touch the code. Did you do anything on your end?

6

There was a feature being rollout with small percentage. Can I still have steps to reproduce in order to prevent this from happening again?

7

Just click on any banner on the dashboard (/app), then from the banner page change something (e.g. icon color), and then click save in the save bar.

1 Like
8

I will report to the team. Thanks for letting us know :person_bowing:

9

No problem, thanks for the quick response.

10 
<SaveBar
  id="editor-modal-save-bar"
  discardConfirmation={isOpen ? true : undefined}
>
  <button
    variant="primary"
    loading={articleIsSaving ? "true" : undefined}
    onClick={() => {
      sendArticleSaveBroadcast(tabId);
    }}
  >
    Save
  </button>
  <button
    onClick={() => {
      closeEditorModal();
    }}
  >
    Discard
  </button>
</SaveBar>

Hi @Henry_Tao, i’m facing similar issue on old polaris react app. any idea how i can show the loader on the save button?

already tried passing empty string “”, true as boolean and string nothing works.