[Urgent] Buttons no longer appearing in modals

Polaris
1

Merchants are reporting that buttons are no longer appearing in modals and I can confirm:

image
image1288×356 10.8 KB

This is how it should render:

image
image1268×472 25.3 KB

I stripped down the modal to the following for testing:

<s-modal id="line-discount-modal">

    <s-button
        slot="primary-action"
        variant="primary">
        Apply
    </s-button>
    
</s-modal>

It only works when the page with the modal is refreshed, if the merchants goes to a different page (ajax/xhr based routing) and tries again, the issue is back and the buttons won’t appear.

It seems that:

According to the docs, these should be the same but the file content for both versions is different

image
image1678×584 57.3 KB

2

Hey Philo, we’re taking a look into the issue. In the meantime you can pin to polaris-1.0.js to unblock merchants.

3

@Philo are you able to provide more details on the framework you’re using, or how you’re populating the modal? I’m not able to reproduce the issue. Any information you can provide that will help us narrow down would be helpful.

4

Thanks @David-Shopify

I’m using Laravel + Livewire’s wire:navigate feature, similar like Turbolinks. Any idea why polaris.js and polaris-1.0.js are not the same though?

5

Thanks for that, we were in process of promoting the 1.1 into the stable channels. I’m going to take a look at reproducing the issue. This didn’t come up during the release candidate soak period we had.

6

Interestingly (and possibly related), anybody who is getting the new Shopify Admin UI and seeing modals inside of apps still running Polaris React are getting modals with really large padding in the footer/button section:

image
image1426×802 59.9 KB

We haven’t adopted the Polaris Web Components yet, but our React components change on this new UI.

7

@marcbaumbach that’s a separate issue, taking a look at it but it’s not related.

8

@Philo we have deployed an update to https://cdn.shopify.com/shopifycloud/polaris-1.1-rc.js can you verify that this has resolved the issue?

9

@David-Shopify I can confirm that the issue is resolved when using the 1.1-rc.js release :slight_smile: Thanks for the quick update.

10

@marcbaumbach the issue you reported should also be fixed now.

11

Thank you! I can confirm it’s fixed.