Warning on buttons with icons

Polaris
1

Hello,

Considering the following HTML:

<s-button href="#" target="_blank" icon="smiley-sad" variant="secondary">Hello</s-button>

Polaris will complain will the following warning (the accessibilityLabel is not needed here as ti is not an icon-only button):

The icon-only button with icon=“smiley-sad” must also have an “accessibilityLabel” property.

Thanks!

2

If you’re using raw HTML, then yeah; we’re aware that our warnings are not quite working correctly for raw HTML. This will apply to the majority of our warnings.

4

I’m using it in React :).