Github Integration Deleting Git Submodule

Short description of issue

The Github integration has started deleting my git submodule even though it is listed in the .shopifyignore file

Reproduction steps

I don’t have a specific set of reproduction steps. It’s just happening sometimes randomly. It’s just if you have the submodule in a theme repo

Additional info

I’ve had other weird issues with the github integration being unreliable

What type of topic is this

Bug report

Hey Jason! I’m pretty sure the GitHub integration does not support .shopifyignore but I find it odd that it would delete random files outside the scope of a theme.

What does the structure of your repo look like?

Hey! Thanks for the reply

The repo structure is the standard shopify theme folders at the top level and then some other folders like apps/, .vscode/, some files, and the git submodule folder also at the top level

All of which are in the .shopifyignore

Very weird! I’ll send you a DM to get a little more information so that we can sift through some logs.

To wrap this one up: we should no longer be deleting any non-blob files when syncing back to GitHub. Your submodule(s) should be untouched moving forward. If you see anything amiss please feel free to fire up a new thread.

Awesome! Thanks so much, I’ll keep an eye out for this issue but really happy to hear it is probably solved!