Deeplinking opens the wrong extension if it has the same handle

Extensions
1

Hello, I found this bug today by accident.

If a store has two apps that contain the same handle, the theme editor will open both extensions in the list, but will scroll to the first one in view.

Example scenario:

Consider this deep link where the handle is themeCSS:

shopify:admin/themes/current/editor?context=apps&template=product&activateAppId=APP_ID/themeCSS

Expected behavior:

It should open only the extension under this path:

https://admin.shopify.com/store/STORE/themes/THEME/editor?context=apps&previewPath=%2Fproducts%2FPRODUCT&appEmbed=APP_ID%2FthemeCSS

Actual behavior:

If another app uses the same handle, it will also be expanded, example:

https://admin.shopify.com/store/STORE/themes/THEME/editor?context=apps&previewPath=%2Fproducts%2FPRODUCT&appEmbed=ANOTHER_APP_ID_THAT_HAS_NOTHING_TO_DO_WITH_THE_ORIGINAL%2FthemeCSS
# original extension also gets open but is not in view
https://admin.shopify.com/store/STORE/themes/THEME/editor?context=apps&previewPath=%2Fproducts%2FPRODUCT&appEmbed=APP_ID%2FthemeCSS

User confusion:

If the unrelated app ID appears first in the theme app extension list, users will be confused when the toast message says the app has been activated, but the toggle button appears as turned off.

Actually both apps have been expanded, but only the targeted one was activated and the wrong extension was scrolled into view.

Possible solution

Make the shopify mechanism find the corresponding extension using both the handle and the extension uuid, instead of only the app handle.

2

Hey @David_Arbias, thanks for reporting this, I believe I have seen a similar issue pop up. I’m going to investigate this internally on my end and I’ll loop back with you once I have next steps/more info. Speak with you as soon as I have more to share, appreciate you flagging this!

1 Like
4

Hey @David_Arbias, just following up here with an update. I was able to confirm with our product team that this is a know issue and we are currently investigating this. I can’t guarantee an exact turnaround time or what a fix will look like, but just wanted to reach back out to let you know we are investigating this still.

I’ll loop back here with you once I have more info to share - thanks again for your patience on this.

1 Like
5

Hey @David_Arbias , we’ve pushed a fix recently related to deeplinks within theme app extensions, can you let me know if this has resolved the issue you were seeing?

If not, just ping me here and I can get back in touch with our product team to investigate further. :slight_smile:

1 Like